In the present work visible light active C and Fe modified ZnO photocatalysts were prepared using microemulsion method. The obtained samples were characterized by TG-DTA, XRD, FT-IR, XPS, SEM, EDX, TEM, PL and UV–visible spectroscopy. XRD study reveals that C and Fe modified ZnO have hexagonal wurtzite structure. As the concentration of Fe changes, morphology of ZnO also changes from rod like shape to spherical shape. It was found that C, Fe co-doping improves the photoabsorption capacity of ZnO in visible region (red shift is observed). XPS study reveals that C and Fe are successfully doped into ZnO lattice with Iron in Fe (III) state. PL quenching for C, Fe co-doped ZnO photocatalysts indicates lower recombination rate of excited electrons/holes. As compared to undoped and C doped ZnO, and Fe doped ZnO, the C, Fe co-doped ZnO photocatalysts exhibited much higher photocatalytic activity for 2,4,6-trichlorophenol (TCP) degradation under visible light irradiation. The optimal ratio of Fe is found to be 2.07 wt%. Stability of photocatalyst was investigated up to fourth cycle and is found to be very stable.